Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListBox/ComboBox tests and cleanup ListBox.SendMessage overloads #2703

Merged
merged 3 commits into from
Jan 20, 2020

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Jan 13, 2020

Proposed Changes

  • Add ListBox/ComboBox tests
  • Cleanup ListBox.SendMessage overloads
Microsoft Reviewers: Open in CodeFlow

@hughbe hughbe requested a review from a team as a code owner January 13, 2020 15:11
@hughbe hughbe force-pushed the ListBox-ComboBox branch 5 times, most recently from 1c00265 to 19d7fc5 Compare January 14, 2020 19:03
@hughbe hughbe force-pushed the ListBox-ComboBox branch 3 times, most recently from fbac65e to 15b31c1 Compare January 15, 2020 10:53
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #2703 into master will increase coverage by 0.46797%.
The diff coverage is 80.74074%.

@@                 Coverage Diff                 @@
##              master       #2703         +/-   ##
===================================================
+ Coverage   58.15281%   58.62078%   +0.46797%     
===================================================
  Files           1240        1240                 
  Lines         422989      426632       +3643     
  Branches       38851       38906         +55     
===================================================
+ Hits          245980      250095       +4115     
+ Misses        171637      171188        -449     
+ Partials        5372        5349         -23
Flag Coverage Δ
#Debug 58.62078% <80.74074%> (+0.46797%) ⬆️
#production 31.69875% <52.38095%> (+0.21085%) ⬆️
#test 98.91905% <89.37198%> (-0.01064%) ⬇️

@RussKie RussKie merged commit 7bdaad1 into dotnet:master Jan 20, 2020
@ghost ghost added this to the 5.0 milestone Jan 20, 2020
@RussKie RussKie added test-enhancement Improvements of test source code enhancement Product code improvement that does NOT require public API changes/additions labels Jan 20, 2020
@hughbe hughbe deleted the ListBox-ComboBox branch January 20, 2020 09:01
@ghost ghost locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Product code improvement that does NOT require public API changes/additions test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants